adafruit / adabot

Adabot is our robot friend who helps Adafruit online
MIT License
13 stars 27 forks source link

Add version checking fix, tweak lists #357

Open tyeth opened 1 year ago

tyeth commented 1 year ago
tyeth commented 1 year ago

@ladyada there were a few more issues in the script than I initially thought. This addresses the missing functionality around version numbers, and output list fixes.

jepler commented 11 months ago

@tyeth assuming you have merge permissions, it's fine for you to merge your own PR after it's been approved. If you don't have permissions, I can do it and you can raise the issue of getting merge access at your convenience.

tyeth commented 11 months ago

Thanks @jepler! I've kind of let this one sit while I use it for a while (few more improvements on https://github.com/tyeth/adabot/tree/arduino-ci-ver-bump), although I also thought I did have merge powers, but alas I do not! Don't worry about merging for now, and I'll sort my access this week.

dhalbert commented 11 months ago

I flipped this to draft so it won't get merged yet.