search

adafruit / ci-arduino

A script that will install all of the common dependencies for testing Arduino library builds using Github Actions
MIT License
115 stars 73 forks source link

Adds a configurable timeout for builds #160

Closed brentru closed 1 year ago

brentru commented 1 year ago

cc @ladyada

This pull request adds an optional configurable timeout parameter, --build_timeout, for building larger Arduino sketches or "firmware using Arduino" (like WipperSnapper).

Without this pull request, calls to arduino-cli (and UF2 generation) from within this script will time out and fail without any output.

Tested within Adafruit WipperSnapper PR: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/488

Example failure run, without --build_timeout for ESP32 builds (which take a while to run and fail if they timeout): https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174986510/job/16760853258

Example successful run, with --build_timeout enabled for all builds: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174857439

ladyada commented 1 year ago

looks good go ahead and merge

this email was probably sent with text to speech, thank you for understanding any typos or missing punctuation 😊

On Wed, Sep 13, 2023 at 12:10 PM Brent Rubell @.***> wrote:

cc @ladyada https://github.com/ladyada

This pull request adds an optional configurable timeout parameter, --build_timeout, for building larger Arduino sketches or "firmware using Arduino" (like WipperSnapper).

Without this pull request, calls to arduino-cli (and UF2 generation) from within this script will time out and fail without any output.

Tested within Adafruit WipperSnapper PR: adafruit/Adafruit_Wippersnapper_Arduino#488 https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/488

Example failure run, without --build_timeout for ESP32 builds (which take a while to run and fail if they timeout): https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174986510/job/16760853258

Example successful run, with --build_timeout enabled for all builds: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174857439

You can view, comment on, or merge this pull request online at:

https://github.com/adafruit/ci-arduino/pull/160 Commit Summary

File Changes

(1 file https://github.com/adafruit/ci-arduino/pull/160/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/adafruit/ci-arduino/pull/160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJINUIAXXJX43NRJJ4HO73X2HLJBANCNFSM6AAAAAA4WVYHEA . You are receiving this because you were mentioned.Message ID: @.***>