adafruit / ci-arduino

A script that will install all of the common dependencies for testing Arduino library builds using Github Actions
MIT License
116 stars 73 forks source link

Update pico flash params #161

Closed tyeth closed 1 year ago

tyeth commented 1 year ago

@brentru I was getting flashing errors using the latest CI builds for the PicoW, but v71 (using old CI) works. It appears we don't have a storage partition so I've updated the flash defs, also doing the frequencies while at it (133MHz is top before overclocking).

I did the 8mb boards too, but maybe I should restrict my changes to the tiny_usb definitions of flash partitions, and all rp2040 frequencies.

brentru commented 1 year ago

@tyeth Maybe for now only do the PicoW w/TinyUSB as this issue is affecting those builds on WipperSnapper and we have no reason to change the rest of these definitions atm.

tyeth commented 1 year ago

@brentru hopefully that's okay now.

brentru commented 1 year ago

@tyeth The latest commit updates more than just the picow tinyusb target. Could you only modify the picow tinyusb target in the platform list?

tyeth commented 1 year ago

Sorry @brentru - sorted now. In the back of my mind I was aware of Scott updating the CPY boards which were running flash slower than needed, and i'd previously seen cpu's set slower than needed. I'll be more selective in future. I can always do a second PR for such thoughts.