adafruit / ci-arduino

A script that will install all of the common dependencies for testing Arduino library builds using Github Actions
MIT License
115 stars 73 forks source link

Make it work with Github CI #58

Closed BenoitAnastay closed 4 years ago

BenoitAnastay commented 4 years ago

I adapted the code to make it working with the currently used Github CI

I'll comment the code to explains what I changed and why

As you can see the build passe on both Travis and Github

ladyada commented 4 years ago

nice! do you mind removing the whitespace-only changes on the other files?

BenoitAnastay commented 4 years ago

@ladyada I made no changes on the others files I don't know what happenned i'll try to revert those

ladyada commented 4 years ago

thanks, i marked which ones they are

ladyada commented 4 years ago

thank you! last question, there's build.sh - can we not use install.sh?

BenoitAnastay commented 4 years ago

@ladyada Github do not seem to be able to call a sourced function and after trying to make a messy condition into install.sh i thought it was a better way to separate them but if you know a clean way to merge them, still calling build from argument an not repeating install, I can apply it

I was thinking of something like this

If [No arguments]
Then
 //Install
Else
//Declare functions
//call function argv
Fi

But I didn't manage to make it work, I did not tried a lot because I thought it was messy

BenoitAnastay commented 4 years ago

This way it throw Permission denied on both Github and Travis

BenoitAnastay commented 4 years ago

Ok maybe a chmod issue I'll try again

BenoitAnastay commented 4 years ago

mode change 100644 => 100755 install.sh

Now this should work, it does on my local machine

BenoitAnastay commented 4 years ago

@ladyada So it work on both Github and travis with only install.sh file

Build Status Build Status

ladyada commented 4 years ago

ok we'll try it! thank you so much :)

BenoitAnastay commented 4 years ago

It worked, the commit have the green mark, nice