Change build directory and fix issue #59

adafruit / ci-arduino

A script that will install all of the common dependencies for testing Arduino library builds using Github Actions

MIT License

115 stars 73 forks source link

Change build directory and fix issue #59 #61

Closed BenoitAnastay closed 4 years ago

BenoitAnastay commented 4 years ago

Edit : I also fixed https://github.com/adafruit/travis-ci-arduino/issues/59

I was trying to use deploy with travis and after a debug I realised that the files are accessible throught shell but not for deploy

Example of a working deploy,

deploy:
  provider: releases
  api_key:
    secure: KEY
  file: "$ARDUINO_HEX_DIR/esp8266/Blink/Blink.ino.bin"
  skip_cleanup: true
  on:
    tags: true

It may be a good idea also to add a deploy demo configuration somewhere, maybe in the readme

ladyada commented 4 years ago

hi we're not sure either but things were breaking meanwhile so we had to revert until we can spend more time looking

BenoitAnastay commented 4 years ago

@ladyada the https://github.com/adafruit/travis-ci-arduino/issues/59 issue is due to the fact that the commands aren't sourced and the .travis file wasn't updated

I'll try to fix that

ladyada commented 4 years ago

ok! thanks :)

BenoitAnastay commented 4 years ago

It should be fixed, after reverting .travis.yml it reproduced https://github.com/adafruit/travis-ci-arduino/issues/59 (https://travis-ci.com/adafruit/travis-ci-arduino/builds/141323655)

But with https://github.com/adafruit/travis-ci-arduino/pull/61/commits/8f87204e04c6968e3e9562a0c9545a14ba961e5e i can call those functions either as a command and as argument

It does work as you can see in the logs

The command "build_platform nrf52840" exited with 0.
The command "build_platform esp32" exited with 0.
The command "build_platform uno" exited with 0.
The command "build_platform leonardo" exited with 0.
The command "build_platform zero" exited with 0.
The command "build_platform esp8266" exited with 0.
The command "build_platform m4" exited with 0.

So travis is working the same way as before PR and Github worked too

In the travis file I just removed setuptools, the calls didn't changed

BenoitAnastay commented 4 years ago

@ladyada You can securely merge it now When you asked me to merge build.sh and install.sh I forgot that install.sh was sourcing commands for travis, sorry

ladyada commented 4 years ago

@makermelissa wanna test this tomrorow after mergin?

BenoitAnastay commented 4 years ago

A possible issue with the directory change is that it allow travis to deploy but will require a .gitignore , it's not the only thing that generating files in the repository there is also Adafruit_Test_Library

makermelissa commented 4 years ago

@ladyada, sounds good. @BenoitAnastay, most repos have a.gitignore already.

makermelissa commented 4 years ago

I'm temporarily pointing a PR to BenoitAnastay's repo, so I can test it prior to merging. So far, so good. If that tests good, I'll merge and update my other PR.

makermelissa commented 4 years ago

It seemed to work great. Now to give it a live test.

makermelissa commented 4 years ago

Tested good live.