search

adafruit / ci-arduino

A script that will install all of the common dependencies for testing Arduino library builds using Github Actions
MIT License
115 stars 73 forks source link

doxy_gen_and_deploy.sh assumes it run on Travis #74

Closed edgar-bonet closed 3 years ago

edgar-bonet commented 4 years ago

Although the script attempts to support both Travis and GitHub actions, in some parts it still assumes it runs on Travis. For instance, line 81:

git config user.email "travis@travis-ci.org"

and line 168:

git commit -m "Deploy code docs to GitHub Pages Travis build: ${TRAVIS_BUILD_NUMBER}" -m "Commit: ${TRAVIS_COMMIT}"

This results in commits like this one:

commit 57834c85e08e3dd436743a59b72f2d888dafd2c5
Author: Doxygen CI <travis@travis-ci.org>
Date:   Thu Apr 23 17:51:50 2020 +0000

    Deploy code docs to GitHub Pages Travis build:

    Commit:
ladyada commented 3 years ago

feel free to submit a PR

edgar-bonet commented 3 years ago

I just submitted pull request #91 addressing this issue.