search

adafruit / ci-arduino

A script that will install all of the common dependencies for testing Arduino library builds using Github Actions
MIT License
115 stars 73 forks source link

Github build will break soon, fails on Ubuntu 20.04 #90

Closed zjwhitehead closed 3 years ago

zjwhitehead commented 3 years ago

Currently the actions_install.sh script fails due to unmet llvm requirements in Ubuntu 20.04 image

The example_actions.yml as well as many other libraries specifies runs-on: ubuntu-latest

image

Github indicates the transition to 20.04 for ubuntu-latest is already happening which means more builds will start breaking soon.

Potential fix

changing in actions_install.sh to use libllvm8=1:8.0.1-9 -V seems to work but needs further testing. Also its not backwards compatible with 18.04 so further work will be required to update the script to handle both versions. image

Bonus: For now pinning the example config to ubuntu-18.04 is probably worth it...

ladyada commented 3 years ago

hmm! can you submit a PR? we'll try it out :)

dhalbert commented 3 years ago

Stopgap fix: https://github.com/adafruit/Adafruit_Learning_System_Guides/pull/1474 for now. We should update the whole clang-format checker.

ladyada commented 3 years ago

this was fixed i guess cause it works now!