Closed 2bndy5 closed 9 months ago
can you put this in as a PR so that we can see what the CI thinks about the proposed change?
I can draft up something. But I can't test anything in Travis CI anymore.
we don't use travis anymore for anything circuitpython related
Should I remove that travis-specific code block? If so, I think the README should also be adjusted accordingly.
Correcting the README with current info would be good, but let's handle the pkg_resources problem separately from that.
Using python 3.12 to build bundles results in the following error:
setuptools
has a migration guide (frompkg_resources
toimportlib.resources
).Possible replacements
https://github.com/adafruit/circuitpython-build-tools/blob/9f02e3a1c9d017e6b76aac106efebf7d2b0c0b6d/circuitpython_build_tools/scripts/build_bundles.py#L271-L272 could be replaced with the suggestion from the aforementioned migration guide.
https://github.com/adafruit/circuitpython-build-tools/blob/9f02e3a1c9d017e6b76aac106efebf7d2b0c0b6d/circuitpython_build_tools/scripts/build_bundles.py#L247-L250 could be replaced with
importlib_metadata.version()
TBC
I haven't delved into the impact of these changes, but I figure d I'd better open an issue to track this for future support of python 3.12.