search

adafruit / circuitpython-build-tools

Build scripts for CircuitPython libraries and the bundle
MIT License
28 stars 18 forks source link

addresses #103 #105

Closed 2bndy5 closed 9 months ago

2bndy5 commented 9 months ago

This is not formatted. I couldn't see anything about contributing guidelines other than code of conduct. Is black used for this project? It doesn't seem like it.

I did run this locally (on Windows with python v3.11.5) and everything seemed to work as expected. However, the newer importlib_metadata.version() returned a dev spec that wasn't PEP440 compatible; I'm not sure that really matters since I think only stable version specs are used for uploads to pypi.

tested with a single module package (circuitpython-cirque-pinnacle) and a multi-module package (circuitpython-nrf24l01)

other chores

jepler commented 9 months ago

If at any point this starts to feel like too much of a moving target, feel free to say so and we can get some element of it merged because that's better than fixing anything (and part of why I split off the README into a separate issue)

2bndy5 commented 9 months ago

If at any point this starts to feel like too much of a moving target, feel free to say so and we can get some element of it merged

I hadn't considered the administrative side of this (upgrading minimum supported python, etc). My main focus was to just fix support for python v3.12 (& ensure backward compatible behavior).

As you pointed out, the newer CI (composite) workflows are pinned to using a python v3.11, so there's probably no rush on this from the average end-user perspective. ~It would be good to prevent upgrading the composite workflows' python pinned version (for now).~

jepler commented 9 months ago

thank you