adafruit / circuitpython-build-tools

Build scripts for CircuitPython libraries and the bundle
MIT License
28 stars 18 forks source link

Memento Camera Project Bundle not including library dependencies #112

Closed djecken closed 7 months ago

djecken commented 7 months ago

When testing the download project bundle from the fancy camera (https://learn.adafruit.com/adafruit-memento-camera-board/fancy-camera ) page on the memento learn guide, the zip file does not include all of the necessary libraries, only the adafruit_pycamera library is added.

jedgarpark commented 7 months ago

@TheKitty I'm not git savvy enough to know how to troubleshoot this.

jepler commented 7 months ago

I suspect that's because the pycamera library fails to declare its dependencies. Transferred. I'll look into it tomorrow; I know how to troubleshoot & test.

jepler commented 7 months ago

however, this looks fine ... https://github.com/adafruit/Adafruit_CircuitPython_PyCamera/blob/main/requirements.txt

jepler commented 7 months ago

bundle json has the following which also looks right:

{
  "dependencies": [],
  "external_dependencies": [
    "adafruit-circuitpython-aw9523",
    "adafruit-circuitpython-busdevice",
    "adafruit-circuitpython-debouncer",
    "adafruit-circuitpython-display-text",
    "adafruit-circuitpython-lis3dh",
    "adafruit-circuitpython-neopixel"
  ],
  "package": true,
  "path": "lib/adafruit_pycamera",
  "pypi_name": "adafruit-circuitpython-pycamera",
  "repo": "https://github.com/adafruit/adafruit_circuitpython_pycamera",
  "version": "0.0.7"
}

however this seems not to cause bundlefly or the screenshot maker to actually include these dependencies. Is it that these things should be in dependencies[] instead of external_dependencies[]? or something else.

BlitzCityDIY commented 7 months ago

hihi- i heard about this and did some testing and i don't think it's a pycamera issue- seems to be a bundle fly issue. i went to this guide: https://learn.adafruit.com/disconnected-co2-data-logger/coding-the-disconnected-co2-data-logger and when i downloaded the bundle it only had the rtc and scd40 libraries, no bus device or register. i went to the scd40 product guide and experienced the same behavior and the screenshot generated also only showed the device library, not the dependencies: https://learn.adafruit.com/adafruit-scd-40-and-scd-41/python-circuitpython#circuitpython-usage-3101400

jepler commented 7 months ago

Based on @BlitzCityDIY's comment and my own research, it seems this is a problem in circuitpython-build-tools. Most likely I introduced it in #110.

The fallout is that dependencies became listed in `e