search

adafruit / circuitpython-build-tools

Build scripts for CircuitPython libraries and the bundle
MIT License
28 stars 17 forks source link

add skip_failed flag #121

Closed FoamyGuy closed 1 month ago

FoamyGuy commented 1 month ago

Resolves: #120

This adds a new --skip_failed flag to the CLI and relevant python functions, it defaults to False if unused so behavior stays the same as today.

If the new flag is passed it will continue the build process instead of bailing after a failed build within a library.

I will open a PR shortly in the community bundle that will utilize this flag to allow it build what it can even if some libraries do fail.

An open question that I'm interested in thoughts on is what to do in the case of the failed builds. It will still print the errors in the actions output, but with the Task passing it's unlikely to be seen there by anyone. I would guess without some other mechanism the most likely time it would be discovered is when someone tries to find that library within the bundle and is unable to.

Maybe a notice message or warning message

FoamyGuy commented 1 month ago

Closing this in favor of: https://github.com/adafruit/adabot/pull/378

I do still think it would make sense for the actions to test against the Adafruit Bundle instead of the community one. But that could be done separately and doesn't need this skip_failed concept to exist.