search

adafruit / circuitpython-build-tools

Build scripts for CircuitPython libraries and the bundle
MIT License
28 stars 17 forks source link

build_bundles: Ignore more packages that exist only on pypi #90

Closed jepler closed 2 years ago

jepler commented 2 years ago

…and sort the existing list and use 'normalized' names

The implementation of normalize_dist_name is taken from pipkin. @aivarannamaa hopefully you can update this list once this PR is confirmed and merged.

@ladyada pipkin copies this list so we should make sure it's up to date on our end!

This list is based on all lines we list in a "requirements.txt" in the adafruit bundle, minutes the ones named adafruit-circuitpython-. Plus numpy and scipy which aren't actually USED at this time, but are added speculatively since dual-purpose code can work with ulab or with numpy.

aivarannamaa commented 2 years ago

To be clear -- is it OK if pipkin always installs adafruit_bus_device if it's specified as dependency and simply ignores the warning at https://pypi.org/project/adafruit-circuitpython-busdevice/#description:

If both the builtin and add-on adafruit_bus_device packages are present, then some libraries that require this package might have problems importing it.

?

Do you know what exactly could this potential problem be?

jepler commented 2 years ago

I'm not sure what that text means. From my understanding depending on the content of sys.path one will be preferred to the other.