search

adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
Other
4.04k stars 1.2k forks source link

PYPORTAL: wiped itself (several times) #1577

Closed TG-Techie closed 5 years ago

TG-Techie commented 5 years ago

i was running code that worked perfectly before but after updating to the most recent master it started hard crashing and then wiped itself

TG-Techie commented 5 years ago

working on reconstructing the lost code as an example

TG-Techie commented 5 years ago

it's done it two more times.
iv'e been working on: https://github.com/TG-Techie/pyportal_gui i wish i could be more specific, this is mostly reconstructed code

TG-Techie commented 5 years ago

ah, i just tried it with 4.0.0-beta.2-36-g66b0c67f5-dirty on 2019-02-12 and it happened again hrmmmm (i saved an old compile)

dhalbert commented 5 years ago

~~I think I know what this might be. I might have messed up declaring MICROPY_PORT_ROOT_POINTERS in the big refactor. @ladyada Will investigate further~~

dhalbert commented 5 years ago

No, that's not it.

tannewt commented 5 years ago

Since you have a JLink, it'd be awesome if you could have a debug build running through the JLink as you work with it. Set a breakpoint on reset_into_safe_mode. It will likely be triggered when the USB dies for you. If it doesn't, you can still control-c it to get a backtrace. You may also want to power the pyportal separately through a stemma connector so that you can unplug usb when it misbehaves. I use gnd and 5v from a grand central or metro to power the pyportal.

TG-Techie commented 5 years ago

I'll be free at 3 to do so until 4. I do not know what a debug build is nor am I super experienced with a Jlink. Is there a guide you know of ?

siddacious commented 5 years ago

This is the one I used; I hear the author went on to do great things https://learn.adafruit.com/debugging-the-samd21-with-gdb/overview

siddacious commented 5 years ago

JLinkGDBServer -speed 4000 -if SWD -device ATSAMD51P20 is the gdb server command I use for the GC which I think is the same for the pyportal?

TG-Techie commented 5 years ago

try these two firmwares, I find the one without init does not have the problem wout_init_firmware.uf2.zip firmware.uf2.zip

ladyada commented 5 years ago

TG, when commenting on issues - please add more information so we know what you're doing and what the firmware you are posting does: what 'init code'? how did you verify 'it does not have the problem' during test? we cannot debug, read, or analyze uf2 files :)

more detail, information, and code is better, while keeping the information relevant and on topic will help us help you!

TG-Techie commented 5 years ago

I duplicated the pyportal board profile and changed the board.c to match the board.c from metro m4, thus board.DISPLAY is a Nonetype in code, and I have not been having the file/folder (and occasional) corruption problem while saving or reloading in addition to far fewer safe mode alerts. The board i am running it on is in spi mode, if relevant.

ladyada, thank you for the feedback you have been giving I have been finding it very useful and I hope I can someday use it in a job. :-)

ladyada commented 5 years ago

ok thanks - next up, when you get safemode alerts what are they saying? do you have a screenshot? they have the reason for safemode

TG-Techie commented 5 years ago

to get the pyportal to output this error I just saved the same main.py over and over, using the program in between saves, until it went to safe mode (took three tries). I was using the most recent master (see below for the build number).

Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.

You are running in safe mode which means something unanticipated happened.
Looks like our core CircuitPython code crashed hard. Whoops!
Please file an issue at https://github.com/adafruit/circuitpython/issues
 with the contents of your CIRCUITPY drive and this message:
Crash into the HardFault_Handler.

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 4.0.0-beta.2-99-gf3e50b9df on 2019-02-21; Adafruit PyPortal with samd51j20
TG-Techie commented 5 years ago

after i power cycled the drive was wiped again

dhalbert commented 5 years ago

@tannewt I think one thing to check here is if a displayio-related object (or maybe a filesystem-related object) should be part of the root pointers lists, but is not. I had a crashing (not a filesystem issue) due to forgetting this for an internal BLE linked list.

@TG-Techie What editor and what operating system are you using? (MacOS for the latter, right?)

uhrheber commented 5 years ago

I don't know whether it's related or not, but I built the latest version from the repository, and tried adafruit_ble with the echo example. It ran perfectly at first, but then I added some code to show the bluetooth status with the onboard LEDs, and after several restarts, both by saving the file and CTRL-D, the virtual drive was wiped.

Version: Adafruit CircuitPython 4.0.0-beta.2-111-gd218069f0 on 2019-02-22; PCA10059 nRF52840 Dongle with nRF52840

TG-Techie commented 5 years ago

@dhalbert. Yes, I'm a Unix/Macos person through and through. I'm using mu 1.0.2.

uhrheber commented 5 years ago

There seems to be something wrong with the filesystem drivers, after reformatting the virtual drive, and reflashing, I got all sorts of weird errors, like:

main.py output: Traceback (most recent call last): File "main.py", line 1, in File "/lib/adafruit_ble/init.py", line 1, in NameError: name 'ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ' is not defined

But when I open the file init.py in an editor, everything looks OK.

TG-Techie commented 5 years ago

@uhheber what do you mean by main.py output? Via repl? Is init seperate from main ?

uhrheber commented 5 years ago

*** This code works: ####################################### from adafruit_ble.uart import UARTServer import board, digitalio

ledg = digitalio.DigitalInOut(board.LED2_G) ledg.direction = digitalio.Direction.OUTPUT ledb = digitalio.DigitalInOut(board.LED2_B) ledb.direction = digitalio.Direction.OUTPUT

uart = UARTServer()

while True: uart.start_advertising() ledg.value = False ledb.value = True

Wait for a connection

while not uart.connected:
    pass

while uart.connected:
    # Returns b'' if nothing was read.
    ledb.value = False
    one_byte = uart.read(1)
    if one_byte:
        uart.write(one_byte)`

########################################

*** This code produces an error: ############################################ from adafruit_ble.uart import UARTServer import board, digitalio

ledg = digitalio.DigitalInOut(board.LED2_G) ledg.direction = digitalio.Direction.OUTPUT ledb = digitalio.DigitalInOut(board.LED2_B) ledb.direction = digitalio.Direction.OUTPUT

uart = UARTServer()

while True: uart.start_advertising() ledg.value = False ledb.value = True

Wait for a connection

while not uart.connected:
    pass

while uart.connected:
    # Returns b'' if nothing was read.
    ledb.value = False
    ledg.value = True
    one_byte = uart.read(1)
    if one_byte:
        uart.write(one_byte)

##############################################

The error is: Traceback (most recent call last): File "main.py", line 1, in NameError: name 'ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ' is not defined

This is reversible! When I remove the line 'ledg.value = True', the error is gone, when I add it (regardless whether I paste it, or type it in letter by letter), the error appears.

The error is independent from the used editor (Mu, gedit, Notepad++) and the OS (Windows 10, Linux Mint 19.1).

dhalbert commented 5 years ago

@uhrheber Could you say exactly which commit you built, or which UF2 you used? The commit listed in the startup prompt is apparently not accurate.

jerryneedell commented 5 years ago

I just tried the error prodcing code both manually as test.py and as main,py -- it does produce an error as main.py but it runs normally as test.py


Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.
main.py output:
Traceback (most recent call last):
  File "main.py", line 1, in <module>
NameError: name '�����������������������������������������������������������������������������������������������������������������������' is not defined

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 4.0.0-beta.2-111-gd218069f0 on 2019-02-22; PCA10059 nRF52840 Dongle with nRF52840
>>> import test

test.py


from adafruit_ble.uart import UARTServer
import board, digitalio

ledg = digitalio.DigitalInOut(board.LED2_G)
ledg.direction = digitalio.Direction.OUTPUT
ledb = digitalio.DigitalInOut(board.LED2_B)
ledb.direction = digitalio.Direction.OUTPUT

uart = UARTServer()

while True:
    uart.start_advertising()
    ledg.value = False
    ledb.value = True
    # Wait for a connection
    while not uart.connected:
        pass

    while uart.connected:
        # Returns b'' if nothing was read.
        ledb.value = False
        ledg.value = True
        one_byte = uart.read(1)
        if one_byte:
            uart.write(one_byte)
jerryneedell commented 5 years ago

ha! but it runs normally if named code.py ??

Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 4.0.0-beta.2-111-gd218069f0 on 2019-02-22; PCA10059 nRF52840 Dongle with nRF52840
>>> 
>>> 
soft reboot

Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.
code.py output:
jerryneedell commented 5 years ago

my tests were on a pca10059 dongle with a build from the current master as of a few hours ago as you can see in the output. Looks like the same commit referenced with the error report above. I have not had any issue where the File system has been wiped by a control-D

TG-Techie commented 5 years ago

Hrmmm I find mine crashes and wipes regardless of file content.

uhrheber commented 5 years ago

@dhalbert Git log says: commit d218069f03451e74e049b337830cbd1be7a25d8e (HEAD -> master, origin/master, origin/HEAD) Merge: 3e877e0f6 ed1ace09e Author: Dan Halbert halbert@halwitz.org Date: Thu Feb 21 17:15:50 2019 -0500

Merge pull request #1584 from tannewt/disable_concurrent_write_protection

Add option to disable the concurrent write protection

commit 3e877e0f6a05083980d5829e8fcc948a14642d58 Merge: 0261c57d3 1532863d8 Author: Scott Shawcroft scott@tannewt.org Date: Thu Feb 21 13:36:26 2019 -0800

Merge pull request #1580 from cpforbes/cpf-1572

Set __file__ for the main source file (e.g. code.py, main.py)

commit 0261c57d32310a0c14703de3c197b700f9f401c3 Merge: b8678c936 01e5a82f1 Author: Scott Shawcroft scott@tannewt.org Date: Thu Feb 21 13:24:07 2019 -0800

Is that what you wanted to know?

Bootloader is: UF2 Bootloader 1.00 Model: Adafruit PCA10059 Board-ID: NRF52-Bluefruit-v0 Bootloader: s140 6.1.0 r0 Date: Oct 2 2018

jerryneedell commented 5 years ago

Now I reloaded it as main.py and it works fine ...

It may be very important to make sure the File sytem has been updated before resetting - on linux I do "sync" after any write to the board.

I had some odd behaviors with trying to load another file and execute it from the REPL -- it resulted in the same "NameError: name= junk " error as above until I reloaded

after that even the previous;y failing main.py started working. So it may all be related to not having the FS stable when resetting

uhrheber commented 5 years ago

@jerryneedell I don't think that this is the root cause. I had the code that produces the error in main.py, and it was synced, because I could read it with another editor. I then ejected the stick (in Linux), unplugged and replugged it. After that, the file system was wiped clean.

Is there something I can check? I have a pca10056 and several pca10059 with debug connector, and a J-Link.

jerryneedell commented 5 years ago

I'm not sure what to suggest, just sharing my observations -- at this point, I cannot reproduce the error ...

I have corrupted many a file system by not properly syncing the system before a hard reset or power cycle.

uhrheber commented 5 years ago

It's definitely not the write cache, I disable write caching for the circuitpython drive in Linux, but nevertheless I get the error.

Also, there seems to be an error in adafruit_ble, because even when it works, I can send only a few characters at a time, when I send more than ~10, CircuitPython crashes:

Traceback (most recent call last):
  File "main.py", line 26, in <module>
  File "adafruit_ble/uart.py", line 128, in write
OSError: Failed to notify or indicate attribute value, err 1304x
uhrheber commented 5 years ago

I just noticed, that the code runs when I add a '#' at the end of the lines that cause an error.

ledb.value = True

crashes, while

ledb.value = True #

works.

Any explanations?

Nevertheless, after replugging, the drive is wiped clean.

uhrheber commented 5 years ago

p.s. it seems to have something to do with the ble library, or external libraries in general, because code using only internal libraries works without a problem, and I can unplug and replug the stick as often as I want, without any problems.

jerryneedell commented 5 years ago

It may be consistent with access to the file system — loading an external library has to read it from the file system.

dhalbert commented 5 years ago

@uhrheber Your testing is on a PCA10059, which uses the internal flash as CIRCUITPY. On the chance that there’s a bug in the internal flash code, could you test on the PCA10056 as well?

Also, please turn off the special mount options you are using, and just do sync after writing, to avoid any possible Linux driver issues.

What text editor are you using?

You mentioned resetting the board frequently. When do you do that? What are the steps of your workflow?

Thanks.

uhrheber commented 5 years ago

I don't use special mount options, I just disabled the write cache. Also, as I already said, it's independent from the OS. Text editors: Windows: Notepad++, Mu Linux: Gedit, Mu

I said nothing about resetting the board. It doesn't matter whether I use the OS' drive eject function before unplugging it, the file system gets wiped anyway.

When I don't use external libraries, I can do with the board what I want, nothing breaks the drive, not even unplugging it while it runs.

uhrheber commented 5 years ago

PCA10056 works without a problem, even when I unplug it while it's running, there's no drive corruption. So your assumption about a bug in the internal flash code is most likely right.

dhalbert commented 5 years ago

@uhrheber Which board(s) are you these problems on?

dhalbert commented 5 years ago

Our comments crossed. Thanks!

uhrheber commented 5 years ago

Only pca10059 so far, I have some nRF52840 based modules from Fanstel here, but didn't test them so far. They don't have external memory, so they should behave exactly as the pca10059.

TG-Techie commented 5 years ago

are we proceeding under the assumption that the two problems are linked ?

uhrheber commented 5 years ago

But why is TG-Techie having these problems with the PyPortal? It HAS external flash.

dhalbert commented 5 years ago

There may be several problems here. @uhrheber’s issue definitely seems related to internal flash. Yours seems to be related to displayio, which they’re not using.

TG-Techie commented 5 years ago

I think i is worth pointing out I do have displayio compiled into the firmware, I only call release_displays, but it has no pre-initialised display. also that my hardware config does not match the software when init_display is enabled is how i put that clear?

TG-Techie commented 5 years ago

i have also noticed my tricorder, basically a stock m4, does not have the file loss issue.

uhrheber commented 5 years ago

BTW, the problem with ble.uart still exists also on the pca10056. When I send more than a few characters at once, the program crashes:

 File "main.py", line 28, in <module>
  File "adafruit_ble/uart.py", line 128, in write
OSError: Failed to notify or indicate attribute value, err 1304x
TG-Techie commented 5 years ago

@uhrheber should that go in a separate issue?

uhrheber commented 5 years ago

Definitely. It's a different problem.

TG-Techie commented 5 years ago

I wonder if this is happening on the hallowing?

ladyada commented 5 years ago

TG - what if you have the backlight very dim, but using the displayio interface - please try that!