Allow displayio to treat all SPI parameters as commands

adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers

https://circuitpython.org

Other

4.11k stars 1.22k forks source link

Allow displayio to treat all SPI parameters as commands #1750

Closed makermelissa closed 5 years ago

makermelissa commented 5 years ago

The SSD1331 likes everything sent as commands. I could format the INIT data as all commands, but that gets lengthy, so it would be nice to just pass a parameter to allow this to happen automatically. Additionally all of the boundary parameters need to be treated as commands too.

deshipu commented 5 years ago

I think all displays want parameters as commands. Data is strictly only for pixel data.

tannewt commented 5 years ago

I checked the ST7735R datasheet and it says parameters are data. (See the D/C column below.)

Screen Shot 2019-04-05 at 11 16 19 AM

deshipu commented 5 years ago

You are right, I tested it with DC=0 and it doesn't work on that display then. Sorry for the assumption.