Closed makermelissa closed 4 years ago
Unfortunately, I'm not the greatest at dealing with multiple branches on such a complex repo, so I'm not sure the best way to go about it.
So after it's fixed manually by https://github.com/adafruit/circuitpython-org/pull/344, we need to rename the board before doing any more 4.x releases (per discussion with @makermelissa in discord).
It might need to be fixed before the next 5.x release if the data files are completely regenerated.
I can add renamed assets in the 4.1.2 release to match the new board name, so that the links will continue to work. Where are the board names extracted from: the last release to generate the circuitpyhon-org PR, or somewhere else?
You don't need to rename the assets. I'm pointing to the current ones.
I think you just need to change the folder name under ports/atmel-samd/boards
@wallarug See above. The robohatmm1 in the 4.x tree is a SAMD21 board. Is that discontinued? Are you expecting everyone to use CircuitPython 5.x now? If that's true, we could just remove the board from 4.x. Thanks for looking.
Hey @makermelissa and @dhalbert
Please remove robothatmm1 from the 4.x tree. We are only making the SAMD51.
If you feel so inclined, the robohatmm1_m4 from the master branch can be put onto 4.x as well.
AFAIK from when I last touched this there was no build issues with robohatmm1_m4 on any of the Circuit Python repositories.
Can this issue be closed now? @dhalbert @makermelissa
Yeah, I'm good with closing it.
Fixed by #2415.
This is causing an issue on the build names and how the boards show up on circuitpython.org