adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
Other
4.12k stars 1.22k forks source link

Can't disable mass storage for the Pimoroni tiny 2040 #4417

Closed ArielWolle closed 3 years ago

ArielWolle commented 3 years ago

Error when building lastest firmware (git clone https://github.com/adafruit/circuitpython.git)

Code/REPL

adding the line: CIRCUITPY_USB_MSC = 0 to /ports/raspberrypi/boards/pimoroni_tiny2040/mpconfigboard.mk results in a build error

Behavior

image

Description

Trying to disable mass storage as i need to write to the tiny 2040 using the storage module but dont want to eject every time i plug it in. Being used as an HID device so needs to be plugged into data and power of usb not just power. Have not tried any other rp2040 boards, just the tiny 2040.

Removing this line resolves the issue.

ladyada commented 3 years ago

@ArielWolle wanna try submitting a PR where the line is behind an #ifdef or #ifnef (the url isnt working)

dhalbert commented 3 years ago

We thought this was fixed by #4283, which was merged, so it should be in the latest source base. Could you paste the source URL again?

ArielWolle commented 3 years ago

Just tried rebuilding again using "git clone https://github.com/adafruit/circuitpython.git" and same issue occurs. But the build works as soon as I take that line out

EDIT: worded it super badly

deshipu commented 3 years ago

It's possible it worked with my test board because I had CIRCUITPY_STORAGE disabled.

@ArielWolle which line exactly? Your link point to nowhere.

ArielWolle commented 3 years ago

I added the line CIRCUITPY_USB_MSC = 0 to the bottom of: https://github.com/adafruit/circuitpython/blob/1be5ca7881a8aa8d32a783bc6a94994886463c30/ports/raspberrypi/boards/pimoroni_tiny2040/mpconfigboard.mk

This is what my mpconfigboard.mk board looks like

image

miclooking commented 3 years ago

I added the line CIRCUITPY_USB_MSC = 0 to the bottom of: https://github.com/adafruit/circuitpython/blob/1be5ca7881a8aa8d32a783bc6a94994886463c30/ports/raspberrypi/boards/pimoroni_tiny2040/mpconfigboard.mk

This is what my mpconfigboard.mk board looks like

image

I get the same error when adding CIRCUITPY_USB_MSC = 0 in mpconfigboard.mk for Raspberry Pi Pico. Is there any solution for this? Thanks.