adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
Other
4.13k stars 1.22k forks source link

Lint all the libraries! #475

Closed tannewt closed 6 years ago

tannewt commented 6 years ago

I'm going through and updating the libraries to our new build process and to turn on lint. Here is the process:

  1. Copy .pylintrc from the cookiecutter repo into the new repo.
  2. Add this to .gitignore
    .env
    build*
    bundles
  3. Copy .travis.yml from cookiecutter into the repo overwriting the old version.
  4. Update lines 1 and 3 of the script section of .travis.yml to reflect the driver name.
  5. Add this to all modules in the driver with the correct repo url below the module comment:
    __version__ = "0.0.0-auto.0"
    __repo__ = "<repo url"
  6. Run pylint on all modules and fix all errors.
  7. Run pylint --disable=missing-docstring,invalid-name examples/*.py to pylint all examples and fix all errors.

If you are doing the PR then please check the box below before you start! That way no one else will do it at the same time.

Remaining

Pending PRs

These PRs may need testing before they can be merged.

Complete PRs

These PRs complete with testing and releases!

tannewt commented 6 years ago

Background on the lint configs is available here: https://github.com/adafruit/cookiecutter-adafruit-circuitpython/pull/6

mrmcwethy commented 6 years ago

I will start with MAX7219

mrmcwethy commented 6 years ago

I added AdaFruit_CircuitPython_DHT to list and then converted it.

mrmcwethy commented 6 years ago

I may have lost changes by ladyada and katni. changed your comment for this issue to added a PRs ready for review category. Also tried to reinstate PRs Complete category.

mrmcwethy commented 6 years ago

I as working on Char_LCD and RGB_Display

mrmcwethy commented 6 years ago

I am starting on pylint of SD

mrmcwethy commented 6 years ago

I am picking up SimpleIO.

mrmcwethy commented 6 years ago

i also did wavefrom

mrmcwethy commented 6 years ago

I am starting on HID

tannewt commented 6 years ago

I'm doing IS31FL3731. I believe its the last one.

mrmcwethy commented 6 years ago

There was a lot of work involved with incorporating pylint into the library build process and it is complete. Thanks everyone!