adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
Other
4.11k stars 1.22k forks source link

Remove displayio.Group max_size parameter from libraries #4959

Closed lesamouraipourpre closed 3 years ago

lesamouraipourpre commented 3 years ago

Now that max_size has been disabled in shared-bindings/displayio/Group.c ready for removal in CircuitPython 7, it needs to be removed from all the libraries that make use of it before this can happen. https://github.com/adafruit/circuitpython/blob/37c52110c5fdcc4b47567e85cba628470f658f84/shared-bindings/displayio/Group.c#L45 I propose to work through the libraries and make the necessary PRs. This Issue is intended as a central tracking point which will eventually allow the removal of the parameter from shared-bindings, hopefully before the release-candidate of CP7.

Below is the output of grep -r max_size * | grep -v adafruit_fram | sort against Adafruit_CircuitPython_Bundle/libraries at Fri 16 Jul 17:03:22 BST 2021

drivers/displayio_sh1106/examples/displayio_sh1106_simpletest.py:splash = displayio.Group(max_size=10)
drivers/displayio_sh1106/README.rst:    splash = displayio.Group(max_size=10)
drivers/monsterm4sk/examples/monsterm4sk_pumpkin_shifting_eyes.py:left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_pumpkin_shifting_eyes.py:right_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_rainbow_stars.py:left_group = displayio.Group(max_size=4, scale=3)
drivers/monsterm4sk/examples/monsterm4sk_rainbow_stars.py:right_group = displayio.Group(max_size=4, scale=3)
drivers/monsterm4sk/examples/monsterm4sk_simpletest.py:left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/examples/monsterm4sk_simpletest.py:right_group = displayio.Group(max_size=4)
drivers/monsterm4sk/README.rst:    left_group = displayio.Group(max_size=4)
drivers/monsterm4sk/README.rst:    right_group = displayio.Group(max_size=4)
drivers/ssd1325/examples/ssd1325_simpletest.py:    max_size=10,
drivers/ssd1325/examples/ssd1325_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:text_group_left = displayio.Group(max_size=10, scale=1, x=0, y=6)
drivers/st7735r/examples/st7735r_128x160_colored_labels.py:text_group_right = displayio.Group(max_size=10, scale=1, x=80, y=6)
drivers/st7735r/examples/st7735r_128x160_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_128x160_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=64)
drivers/st7735r/examples/st7735r_minitft_featherwing_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_minitft_featherwing_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=40)
drivers/st7735r/examples/st7735r_minitft_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/examples/st7735r_minitft_simpletest.py:text_group = displayio.Group(max_size=10, scale=2, x=11, y=40)
drivers/st7735r/examples/st7735r_simpletest.py:splash = displayio.Group(max_size=10)
drivers/st7735r/README.rst:    splash = displayio.Group(max_size=10)
FoamyGuy commented 3 years ago

Thanks for putting this together. We'll need to run a similar pass through the learn guide repo to change instances of this as well.

jposada202020 commented 3 years ago

@lesamouraipourpre I give all the thanks here for all these PRs. This is hard work!!!

jposada202020 commented 3 years ago

Arrowline Done --> https://github.com/jposada202020/CircuitPython_ArrowLine/releases/tag/0.8.1 Candlesticks Done --> https://github.com/jposada202020/CircuitPython_Candlesticks/releases/tag/0.6.1 Styles Done --> https://github.com/jposada202020/CircuitPython_styles/releases/tag/0.5.1