Closed lesamouraipourpre closed 3 years ago
Thanks for putting this together. We'll need to run a similar pass through the learn guide repo to change instances of this as well.
@lesamouraipourpre I give all the thanks here for all these PRs. This is hard work!!!
Arrowline Done --> https://github.com/jposada202020/CircuitPython_ArrowLine/releases/tag/0.8.1 Candlesticks Done --> https://github.com/jposada202020/CircuitPython_Candlesticks/releases/tag/0.6.1 Styles Done --> https://github.com/jposada202020/CircuitPython_styles/releases/tag/0.5.1
Now that
max_size
has been disabled inshared-bindings/displayio/Group.c
ready for removal in CircuitPython 7, it needs to be removed from all the libraries that make use of it before this can happen. https://github.com/adafruit/circuitpython/blob/37c52110c5fdcc4b47567e85cba628470f658f84/shared-bindings/displayio/Group.c#L45 I propose to work through the libraries and make the necessary PRs. This Issue is intended as a central tracking point which will eventually allow the removal of the parameter fromshared-bindings
, hopefully before the release-candidate of CP7.Below is the output of
grep -r max_size * | grep -v adafruit_fram | sort
againstAdafruit_CircuitPython_Bundle/libraries
atFri 16 Jul 17:03:22 BST 2021