search

adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
Other
4.09k stars 1.21k forks source link

pimoroni servo 2040: board.NEOPIXEL #6307

Closed jepler closed 2 years ago

jepler commented 2 years ago

The board module has LED_DATA but it should probably be using the standard name NEOPIXEL.

ladyada commented 2 years ago

@ZodiusInfuser

ZodiusInfuser commented 2 years ago

If board.NEOPIXEL is the convention, and the appropriate name for multiple LEDs (rather than board.NEOPIXELS), then this sounds fine to change. I went with LED_DATA because it's more generic and matches the pin name on the schematic. This by extension means our C++, MicroPython, and CircuitPython board definitions are consistent.

Let me know whichever way, as we'll have other board hopefully launching this week with a similar setup that I'm yet to raise the PR for.

ladyada commented 2 years ago

@ZodiusInfuser you can add an alias for NEOPIXEL - please submit a PR :)

jepler commented 2 years ago

CircuitPlayground (Express & Bluefruit), PyGamer, and PyBadge at least have multiple neopixels attached to board.NEOPIXEL, that's not a problem.