adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
MIT License
3.96k stars 1.16k forks source link

Espressif ESP32-S3 DevKit-1 C boards moved NeoPixel pin on board revision #9275

Open dhalbert opened 1 month ago

dhalbert commented 1 month ago

Issue noted in https://forums.adafruit.com/viewtopic.php?t=211010 (wbeebe).

Espressif moved the RGB LED. Quoting from their doc:

Both the initial and v1.1 versions of ESP32-S3-DevKitC-1 are available on the market. The main difference lies in the GPIO assignment for the RGB LED: the initial version uses GPIO48, whereas v1.1 uses GPIO38.

Creating new board defs seems like a bit of a waste. I wonder if we should alias the pins to, say, board.NEOPIXEL_V10 and board.NEOPIXEL_V11, or maybe just omit the name.

bill88t commented 1 month ago

For portable (across boards) code, this would be a bummer. board_id is how code is supposed to tell what it's running on.

tannewt commented 1 month ago

I'd prefer to have new boards for these. That way the status LED will work too. We can use ccache to speed up additional board builds.