adafruit / circuitpython

CircuitPython - a Python implementation for teaching coding with microcontrollers
https://circuitpython.org
Other
4.12k stars 1.22k forks source link

Add global GCC version check #9779

Closed jepler closed 2 weeks ago

jepler commented 3 weeks ago

We can set some of them lower than 13 if necessary on a per-port basis. At least esp32 and arm ports all use 13 from what I could see.

I recently lost some time because CircuitPython for rp2040 built with gcc 10 just didn't work (wouldn't boot). It seems preferable to stop the build if it's an older version of GCC than the one we use in CI, unless we specifically test some older versions.

jepler commented 2 weeks ago

I can change the message because it's not actually the case that e.g., arm gcc 12 is "known to miscompile" the raspberrypi port, but this is the general idea of stopping folks from accidentally building with a gcc version different than what we use during CI