search

adafruit / nofrendo_arcada

NES emulator in Arduino that runs on SAMD51 at full speed w/audio
https://learn.adafruit.com/nes-emulator-for-arcada
57 stars 12 forks source link

Lack of audio volume control #9

Open isopix opened 1 year ago

isopix commented 1 year ago

Lack of audio volume control really sucks and by default it's really loud and annoying on Adafruit PyBadge devices (which lacks potentiometer).

ggsato commented 9 months ago

I'm working on this. My first experiment was to lower the fixed volume to a decent value. Here's the commit.

It seems that the code has existed since its birth. https://github.com/rickyzhang82/nofrendo/blob/master/src/sndhrdw/nes_apu.c#L327-L330

Here's the reference to understand the overall architecture. https://www.nesdev.org/wiki/APU

The next step is to make it adjustable somehow.

ggsato commented 9 months ago

I made a PR #10. Here's a screenshot.

pybadge_volume_menu