adafruit / pi_video_looper

Application to turn your Raspberry Pi into a dedicated looping video playback device, good for art installations, information displays, or just playing cat videos all day.
GNU General Public License v2.0
451 stars 239 forks source link

Background Image doesn't reload after USBcopy #129

Closed lordratner closed 2 years ago

lordratner commented 2 years ago

Hello hello!

First off, thanks for this neat program. I finally isolated an issue I was having. I have looper set up to copy the USB contents to the directory and also copy the background image loader.png. Upon inserting the USB drive, all videos and the loader.png file are copied over correctly. And the video list reloads to reflect the new set of videos in the folder and plays automatically. However there are two problems with the background image.

First, no matter where you have your background image (the default .ini uses /home/pi/static/bg.png), the loader.png from the memory key is loaded to /home/pi/loader.png. So the .ini needs to point to /home/pi/loader.png if you want to use background images loaded from the USB key. It would be better if loader.png on the USB key was copied to the path/filename specified in the .ini for the background image.

Second, after you fix the above issue (setting the image path to /home/pi/loader.png) the program does not load the newly uploaded image after copying it from the USB stick. Whatever the previous image was (including a blank screen if there was nothing) will be the background image until you restart the program.

I'm not sure how to fix it, but I'll dig around in the code and see if I can figure it out, but I suspect someone who is familiar with the program can fix both issues quickly.

Thanks again!

tofuSCHNITZEL commented 2 years ago

Hi, since the path from where the looper picks up the background image is customisable I thought there was no need to also change the target of the png copy in copymode. so cou can just set bgimage = /home/pi/loader.png. tbh I use this image for something else that displays this image on bootup instead of the linux boot text.

The second thing is quite interesting and I will have a look on how to reload the bg image if one was copied.

Thanks for the feedback

tofuSCHNITZEL commented 2 years ago

Hey, could you please clone and try this version: git clone --single-branch --branch copyfeature_update https://github.com/tofuSCHNITZEL/pi_video_looper it should refresh the background image after copying

lordratner commented 2 years ago

Ran the install per the Adafruit instructions, but with that branch, Installation finished but it wont start. When I run sudo supervisor start video_looper I get video_looper: ERROR (spawn error)

Traceback (most recent call last): File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "/usr/lib/python3.7/runpy.py", line 85, in _run_code exec(code, run_globals) File "/usr/local/lib/python3.7/dist-packages/Adafruit_Video_Looper-1.0.8-py3.7.egg/Adafruit_Video_Looper/video_looper.py", line 448, in <module> File "/usr/local/lib/python3.7/dist-packages/Adafruit_Video_Looper-1.0.8-py3.7.egg/Adafruit_Video_Looper/video_looper.py", line 61, in __init__ NameError: name 'config' is not defined

tofuSCHNITZEL commented 2 years ago

Ups, stupid mistake. Please pull it now and try again

lordratner commented 2 years ago

It runs now, but the background image still isn't updating after the USB copies. I confirmed that the file is being replaced with the version on the USB drive. Restarting video_looper corrects it like before. I used the git command you posted, is there a way to confirm I ended up with the correct branch?

tofuSCHNITZEL commented 2 years ago

Okay then I guess I need to do some testing... Will take some time

lordratner commented 2 years ago

Thanks for the help. If there's anything I can do, let me know.

tofuSCHNITZEL commented 2 years ago

sorry for the delay. was actually an easy fix - should have taken more time to think about the code in the first place... anyway its fixed in version 1.0.9.

cheers