adafruit / pi_video_looper

Application to turn your Raspberry Pi into a dedicated looping video playback device, good for art installations, information displays, or just playing cat videos all day.
GNU General Public License v2.0
469 stars 244 forks source link

Block Button Press while playing a video #226

Closed fiete96 closed 3 months ago

fiete96 commented 3 months ago

Hey there, Thanks for this nice Application! but for me there is one thing missing: I would like to an option to deactivate the GPIO Button while the video is playing. so the video doesn't jump to the start of the clip if its already playing and someone presses the button again. I want to use this with the single shot option to play the video once. Thanks a lot!

tofuSCHNITZEL commented 3 months ago

Hi, okay such an option would only make sense if the player "stops" after a video - otherwise the buttons would never work ;) I will see if this is easy to do! cheers

tofuSCHNITZEL commented 3 months ago

Hi, I have implemented in the next branch: https://github.com/adafruit/pi_video_looper/tree/next

clone this instead of main git clone -b next https://github.com/adafruit/pi_video_looper and if you have time please test it - I don't think I have the time right now.

fiete96 commented 3 months ago

Hey!

Thanks! I tried it, but unfortunately, it didn't work. I addressed the video directly in the GPIO Map, but then the function does not work. When I address K_s, it works partially. I cannot play the video from the start while the video is running. However, I think it stored that I pressed it while it was playing, and then it played the video two times.

I hope you understand what I mean. :D

tofuSCHNITZEL commented 3 months ago

sorry I had some stupid oversights in the code I pushed first... all fixed now and I tested it and now it works as expected. please test again ;)

fiete96 commented 3 months ago

Yes it works (I just tested it with "K_s") 👍 Thanks a lot!

tofuSCHNITZEL commented 3 months ago

Great! Its now in the 1.0.19 release version. https://github.com/adafruit/pi_video_looper/releases/tag/v1.0.19