search

adafruit / tinyuf2

UF2 bootloader based on TinyUSB for embedded devices such as ESP32S2, STM32F4 and iMX RT10xx
MIT License
314 stars 172 forks source link

added two smart bee designs boards #237

Closed strid3r21 closed 2 years ago

strid3r21 commented 2 years ago

first time posting a PR in this repo so please let me know if im missing anything or need to change/add more.

thanks

strid3r21 commented 2 years ago

i think its fixed. prettier was adding the additional white spaces when I saved the file.

strid3r21 commented 2 years ago

again, please revert the unnecessary changes to the yml file. Don't edit the whole file, you only need to add your board to the list in ABC order.

What changes are you referring to? All ive done is add my two boards to the list. I thought you were originally referring to the indention being different from the master, but now I'm not sure what you're talking about.

hathach commented 2 years ago

again, please revert the unnecessary changes to the yml file. Don't edit the whole file, you only need to add your board to the list in ABC order.

What changes are you referring to? All ive done is add my two boards to the list. I thought you were originally referring to the indention being different from the master, but now I'm not sure what you're talking about.

there is the "File Changes" tab in the top of the PR, you should always double check that.

strid3r21 commented 2 years ago

again, please revert the unnecessary changes to the yml file. Don't edit the whole file, you only need to add your board to the list in ABC order.

What changes are you referring to? All ive done is add my two boards to the list. I thought you were originally referring to the indention being different from the master, but now I'm not sure what you're talking about.

there is the "File Changes" tab in the top of the PR, you should always double check that.

Oh I think i see what's wrong now. I'll try and fix it in a few hours once I'm home..sorry for the hassle.