search

adafruit / tinyuf2

UF2 bootloader based on TinyUSB for embedded devices such as ESP32S2, STM32F4 and iMX RT10xx
MIT License
314 stars 172 forks source link

Add LOLIN S3 #256

Closed chukwon closed 1 year ago

chukwon commented 1 year ago

Description of Change

only add new board - lolin s3

chukwon commented 1 year ago

add lolin_s3 support, also used by espressif_esp32s3_devkitc_1.1 of n16r8

lyusupov commented 1 year ago

@chukwon 

#define USB_VID           0x239A
#define USB_PID           0x00A5    // TODO temporarily shared with S2 saola wrover

VID 0x239A is assigned to Adafruit vendor.

Would you mind to use the VID/PID from Espressif list ? https://github.com/espressif/usb-pids/blob/main/allocated-pids.txt#L288

0x8118 | Lolin S3 - UF2 Bootloader
chukwon commented 1 year ago

@lyusupov don't mind

hathach commented 1 year ago

@chukwon there is nothing new in the PR, checkout my above review request.

chukwon commented 1 year ago

update completed

hathach commented 1 year ago

update completed

double check the check list, your pr miss ci thing.