Closed lyusupov closed 1 year ago
lyusupov
commented
1 year ago look good, but please remove unused files such as cpp/hpp i.e only included used files.
@hathach All the files in the 'src' folder have references onto each other. Could you, please, be more specific on which files should be removed ? .gitignore ? keywords.txt ? library.json ? library.properties ?
hathach
commented
1 year ago the idea is to remove all source and header aren't used. I don't know which files you use yet. Could you update the PR to also include your BSP as well instead of the component only since they aren't used anywhere.
lyusupov
commented
1 year ago Ok, I see your point... Let to me to explain my one.
I am currently submitting a BSP 'step-by-step'. XPowersLib is the last component used. Next two small PRs will contain rest of the stuff.
Idea of committing the BSP through a sequence of PRs is to ease adoption.
I don't know which files you use yet.
You may see the result in the 'master' branch of this repo: https://github.com/lyusupov/tinyuf2
Please, trust me that the files I commit is a bare minimum.
hathach
commented
1 year ago please also submit the BSP as draft PR, I would like to check to see which files are used in compilation.
lyusupov
commented
1 year ago
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Description of Change
This XPowersLib PMU software component is a prerequisite before adding BSPs for boards that have an onboard display hardware that needs to supply power through the PMU at boot time (such as M5Stack, LilyGO and other brands).
https://github.com/lewisxhe/XPowersLib