adafruit / tinyuf2

UF2 bootloader based on TinyUSB for embedded devices such as ESP32S2, STM32F4 and iMX RT10xx
MIT License
310 stars 170 forks source link

Add ES3ink board #331

Closed dronecz closed 11 months ago

dronecz commented 1 year ago

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes


Description of Change

Add ES3ink board

dronecz commented 1 year ago

Please follow the PR template description and make following changes

  • UF2_BOARD_ID is not correct
  • remove adafruit favicon
  • provide link to vid/pid

I added link for VID/PID to PR comment and fixed issues which you mentioned. Thanks

hathach commented 1 year ago

I added link for VID/PID to PR comment and fixed issues which you mentioned. Thanks

your PID PR is still opened, have you allocated with the PID yet ?

dronecz commented 1 year ago

your PID PR is still opened, have you allocated with the PID yet ?

Sorry, I do not now what you mean by that. Could you rephrase your question? Thanks

hathach commented 1 year ago

sorry, I mean did your request for the PID is accepted yet ?

dronecz commented 1 year ago

No, I'm waiting for somebody to make a review, but I do not expect to be declined. I understand if you want wait until will be accepted.

hathach commented 1 year ago

No, I'm waiting for somebody to make a review, but I do not expect to be declined. I understand if you want wait until will be accepted.

PID approval is mandatory, I will mark this PR as draft for now. Please mark it as ready when you have PID allocated.

lyusupov commented 1 year ago

your PID PR is still opened, have you allocated with the PID yet ?

Sorry, I do not now what you mean by that. Could you rephrase your question? Thanks

https://github.com/espressif/usb-pids