Closed adah1972 closed 7 years ago
One comment before I begin: there's a way to mark a list as a task list in github, maybe consider doing that, so it's easier to follow what's done. :)
As for more specific comments:
Oops, I missed the task list. I will use it next time.
BTW, I may do some reformatting, but won't do it fully automatically—doing so would unalign inline comments. Fully automatic formatting may still be useful in a big project, but I do not feel like doing so in this small project.
I think I am done except the final release. Please help double-check the current status. If you do not see any problems, I'll make a new release.
@tasn A few other minor things I would like to make about Doxyfile, unless you have objections:
To clarify, I would like to include the resulting documentation in the release. That means browsers not supporting SVG files will have trouble viewing the documentation.
don't forget to document this "hidden" feature with the strict linebreaking of the japanese language. Right now it seems like it is only documenting that the language parameter contains the language.
And I also think that it would be nice to mention that the language is supposed to be an ISO 639-1 language code.
No objections, change them as you wish, all sound reasonable.
I made some adjustments to the documentation comments, and made a test release at:
http://wyw.dcweb.cn/libunibreak-4.0.tar.gz
If you do not see any problems, I will add a tag to GitHub and make a formal release in three days.
Haven't tried your test release, but just pulled and ran make check for the last time. Everything still works.
I also ran the test apps with valgrind. Everything looks great.
downloaded the archive and found one issue that needs fixing...
Additionally I do think that the doxygen documentation is not optimal. It contains much more information than required for a user. The user should only get the return enums and the 3 functions that create the breaking information for each breaking type... As it is it documents all these internals that are quite uninteresting for the user. When I started using the library I did use the c files and they did serve me well.... I don't know if it is intended the the doxygen documentation contains all that internal information?
Good catch. src/Makefile.am is now updated.
As to the documentation, I do not think it necessary to remove existing documentation.... Users should normally only check *break.h, but not other files.
Released.
I would like to do the following before the new release:
Please check whether anything is incorrect or missing.