Possible Optimization - Githubissues

adah1972 / libunibreak

The libunibreak library

zlib License

173 stars 38 forks source link

Possible Optimization #32

Closed mta452 closed 3 years ago

mta452 commented 3 years ago

I propose to optimize the usage of memory with following points.

Let GRAPHEMEBREAK values 1-3 , make LINEBREAK values 4-7 , and WORDBREAK values 8-10
Make the client ensure initially all elements of input array are set to 0
Allow grapheme break, line break and word break to work on a single array i.e. commutative

adah1972 commented 3 years ago

Sorry, it does not look like a good idea to me. It will increase coupling among the code, and, besides, since the different kind breaks can happen at the same time, you need bit masks instead of allocating different values in order to allow them to work on the same array.