Added Current Location Feature

adaharshsingh / Propacity

https://propacity-alpha.vercel.app

5 stars 36 forks source link

Added Current Location Feature #26

Closed RishabhSri17 closed 1 month ago

RishabhSri17 commented 1 month ago

This pull request addresses issue #25 ,I had added feature of current location by adding one component LocationCard.jsx and adding few lines of code in /Context/index.jsx and app.jsx .

Change I have made-

Added a LocationCard component that, when clicked, fetches the user's current latitude and longitude using the Geolocation API.
Applied consistent styling to the LocationCard to match the existing CityCard layout.
Integrated the fetched coordinates into the existing weather API to display the weather forecast for the user's current location.

Screenshot - After First Commit - displaying Latitude and Longitude Screenshot 2024-10-07 021544 (2) After Second Commit - displaying Placename instead Screenshot 2024-10-07 021711

Testing:

Tested the feature locally by fetching the location multiple times and verifying the response.

Please accept my pull request and review the changes and let me know if any adjustments are needed. Thank you!

vercel[bot] commented 1 month ago

@RishabhSri17 is attempting to deploy a commit to the adarsh's projects Team on Vercel.

A member of the Team first needs to authorize it.

RishabhSri17 commented 1 month ago

I had added also added feature of displaying Placename instead of Latitude/Longitude , for that we have to update our .env file by adding email-id (to fetch Placename) - ex_email = your_email_id

Screenshot 2024-10-07 024857

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
propacity	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 7, 2024 7:53am

adaharshsingh commented 1 month ago

Hey !! Your current location feature work perfectly ; but its not showing the current city name in my setup ;but it seems to work in your setup ; can you tell me what the problem might be; i have added VITE_EX_EMAIL as a env variable just as you suggested but it doesn't work; Screenshot 2024-10-07 135928

RishabhSri17 commented 1 month ago

Did you push my second commit regarding the place name update? I had updated LocationCard.jsx, and that might be why it's not reflecting. As far as I can see, you updated index.js by changing ex_email to VITE_EX_EMAIL and also added it in the .env file, so it should be working properly.

If there’s anything else I might have missed, please let me know so we can resolve it.

adaharshsingh commented 1 month ago

Its working now , Thanks for your contribution!