adalmia3 / kfm

Automatically exported from code.google.com/p/kfm
0 stars 0 forks source link

No translation from 1.4.4 #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
There is no translation from 1.4.4 (surely, and maybe even before). I've
discovered table "translations" in DB - maybe all translations have to be
put there?

Original issue reported on code.google.com by subog....@gmail.com on 29 Jan 2010 at 3:14

GoogleCodeExporter commented 8 years ago
the database thing was an idea that I had, but it was complex and easy to break.

I've started reverting the code. Please check tonight's nightly version (or 
update
from SVN if you're using that) and reply if the problem is fixed or if you can 
add
more detail about exactly what is broken.

http://code.google.com/p/kfm/source/detail?r=973

Original comment by kae.verens@gmail.com on 31 Jan 2010 at 6:21

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
I've checked tonight code as well as 1.4.4 release - translation works, but 
only when
I call kfm by myself, i.e. when I put kfm call in browser address string, like:
http://.../ckeditor/kfm/?CKEditor=ckeditor1&CKEditorFuncNum=2&lang=ru

When KFM is called by ckeditor it is called so:
http://.../ckeditor/kfm/?CKEditor=ckeditor1&CKEditorFuncNum=2&langCode=ru

Do you see the difference? When it calls automatically a variable is called
"langCode", but the one which does work is being called "lang". That is the 
problem.

I've also checked with earlier versions of KFM and FCKeditor - so it is - simply
"lang=..."
When calling KFM to be used with ckeditor like:
"filebrowserBrowseUrl : '/ckeditor/kfm/?lang=ru'" - it works fine for me.

So, maybe, just to write to those, who use KFM with ckeditor, that they should 
add
"lang=..." when calling it or to use ckeditor variable "langCode".

Original comment by subog....@gmail.com on 1 Feb 2010 at 8:12

GoogleCodeExporter commented 8 years ago
fixed. a single line addition:
http://code.google.com/p/kfm/source/detail?r=976

Original comment by kae.verens@gmail.com on 1 Feb 2010 at 8:50

GoogleCodeExporter commented 8 years ago
Have checked once again with senior programmer - and the only thing which 
doesn't
work quite correct - warnings, which are shown in top right corner with red
background. They are shown in wrong encoding - and you can't understand what is
written there.

Original comment by subog....@gmail.com on 2 Feb 2010 at 8:57

GoogleCodeExporter commented 8 years ago
warnings are displayed by the client-side script, so there should be no encoding
problems.

my guess is that the problem is actually on the server-side - whatever is 
generating
the warning sends it to the client using the wrong encoding.

please tell me what you were doing which generated the warning, so I can track 
it down.

another way to help is to use Firebug (or something similar) to track the server
requests as they are happening - when the warning is displayed, there should be 
a
clue in the HTTP requests.

Original comment by kae.verens@gmail.com on 2 Feb 2010 at 9:19

GoogleCodeExporter commented 8 years ago
I've ment not only errors, but warnings, etc.
for example I've copied a file from a folder to another one and I also have got 
this
message. And this is what firebug shows:
{"results":[null,"window.kfm_closeContextMenu=function(){\n\t$j('.contextmenu').
remove();\n}\n"],"errors":[],"messages":[{"message":"\u00d1\u0081\u00d0\u00ba\u0
0d0\u00be\u00d0\u00bf\u00d0\u00b8\u00d1\u0080\u00d0\u00be\u00d0\u00b2\u00d0\u00b
0\u00d0\u00bd\u00d0\u00be
1 \u00d1\u0084\u00d0\u00b0\u00d0\u00b9\u00d0\u00bb\u00d0\u00be\u00d0\u00b2"}]}
I've checked in Chrome and in Firefox 3.6 - the same problem - wrong encoding.
Just don't understand where it comes from...

Original comment by subog....@gmail.com on 2 Feb 2010 at 9:43

GoogleCodeExporter commented 8 years ago
thanks - I can see what the problem is and I know what the solution is. I'll 
get that
fixed today.

Original comment by kae.verens@gmail.com on 2 Feb 2010 at 9:51

GoogleCodeExporter commented 8 years ago
think I have it now.
some strings were being encoded twice before being sent back to the client.

http://code.google.com/p/kfm/source/detail?r=977

Original comment by kae.verens@gmail.com on 2 Feb 2010 at 6:18

GoogleCodeExporter commented 8 years ago
Now everything is fine :)

Original comment by subog....@gmail.com on 3 Feb 2010 at 4:15

GoogleCodeExporter commented 8 years ago

Original comment by kae.verens@gmail.com on 4 Feb 2010 at 7:27