adalmia3 / kfm

Automatically exported from code.google.com/p/kfm
0 stars 0 forks source link

kfm_prompt opens behind iframe #52

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When an image is cropped, and a new name has to be selected kfm_prompt is 
used. (Impromptu is removed!). This dialog opens behind the iframe of 
cropper.

Original issue reported on code.google.com by bterku...@gmail.com on 22 Feb 2010 at 1:14

GoogleCodeExporter commented 8 years ago
time to start using jquery-ui, I think. this is a job for .dialog()

if you don't get it by the weekend, I'll take care of it on Saturday.

all modal dialogs and prompts in kfm should be changed to use .dialog. it will 
reduce
the code-base we need to maintain.

Original comment by kae.verens@gmail.com on 22 Feb 2010 at 6:48

GoogleCodeExporter commented 8 years ago
The admin area is already 100% jQuery +ui. Maybe it should be introduced to the 
frontend. The Accordion would be nice on the left :) 

Original comment by bterku...@gmail.com on 23 Feb 2010 at 3:42

GoogleCodeExporter commented 8 years ago
I added jquery ui to the frontend and ported kfm_prompt to the .dialog method. 
Seems 
to work like a charm. Now the discussion about the default theme can begin :)

Original comment by bterku...@gmail.com on 23 Feb 2010 at 4:12

GoogleCodeExporter commented 8 years ago
couple of points about the .dialog replacement:

Ok and Cancel are now hard-coded. we should come up with a way to have these 
translated?

if txt is an object (iirc, in some cases a full element is passed instead of a 
text
string), the .dialog will show "Object" as the message, instead of the correct
message. a workaround might be to .append() if it's an object, and use '+' only 
if
it's a string.

"$j(this).dialog('close');" only hides the dialog from view. to remove it 
properly,
use "$j(this).remove();" - this has caught me out /many/ times.

I'll be heading home in an hour or so. I should have a bit of time to look at 
this
properly tonight. these problems should be fixed as soon as possible before we 
forget
them.

Original comment by kae.verens@gmail.com on 23 Feb 2010 at 4:25

GoogleCodeExporter commented 8 years ago
I totally agree. At least the first implementation is really easy. Now the 
special 
cases can be implemented. The rename and crop functions work. For the 
translations to 
work we have to create our own object, not the {} notation I suppose.

Original comment by bterku...@gmail.com on 23 Feb 2010 at 5:10