search

adam-codersgu / supernova

A Kotlin-based Android application that allows the user to play music from their device while custom animations fall over the album artwork of the currently playing song.
0 stars 0 forks source link

Unknown bug introduced #101

Closed adam-codersgu closed 1 year ago

adam-codersgu commented 1 year ago

A bug of unknown cause and resolution was somehow introduced it seems in the last 12 commits (likely earlier) on the master branch. The bug causes the app display to constrict to the point where the app is unusable, seemingly after the app has been running in the background for a while. This usually happens on the homepage, but I just had it happen when I navigated from the homepage to an album. This was originally investigated in https://github.com/adam-codersgu/supernova/issues/96.

I've reverted the app to the last stable commit. The goal now is to gradually reintroduce the work from those recent commits gradually to see when the issue reappears (if the issue was indeed from those commits)

adam-codersgu commented 1 year ago

The last stable commit was 8b223f3 and the issue was observed before March 7th, so if the issue was caused by commits then it would have to be the four from Mar 4, 2023. I've even tried reinstalling the app from scratch and the issue persists

adam-codersgu commented 1 year ago

Branch broken/broken_version_issue_101 contains the broken branch

adam-codersgu commented 1 year ago

Branch release/unstable will contain the changes that are being evaluated and rolled back in

adam-codersgu commented 1 year ago

I think this was resolved by changing supportsUpdateAnimations = false for the DefaultItemAnimator implementation to changeDuration = 0

adam-codersgu commented 1 year ago

https://github.com/adam-codersgu/supernova/pull/102