search

adam-codersgu / supernova

A Kotlin-based Android application that allows the user to play music from their device while custom animations fall over the album artwork of the currently playing song.
0 stars 0 forks source link

Improve the handling of missing custom animation images #19

Closed adam-codersgu closed 1 year ago

adam-codersgu commented 1 year ago

The user can set custom image sources for drawables for the artwork animations. If a custom image is unavailable, then a toast notifcation advises the user of this and an in-house animation option is selected instead. The purpose of this ticket is to enhance this error handling. For example, if other custom images are still available then these could be used instead, and only the offending drawable image could be removed. See the setCustomDrawable method in CurrentlyPlayingFragment for where this error handling occurs

adam-codersgu commented 1 year ago

Working on branch enhancement/missing_custom_image

adam-codersgu commented 1 year ago

Having issues with matters relating to the Google photos API. I suggest to solve all problems in one go, copies of the user's custom animation images should be saved internally then deleted later when no longer needed. This should solve a lot of current and possible future problems

adam-codersgu commented 1 year ago

Completed and merged https://github.com/adam-codersgu/supernova/pull/48