search

adam-codersgu / supernova

A Kotlin-based Android application that allows the user to play music from their device while custom animations fall over the album artwork of the currently playing song.
0 stars 0 forks source link

Bug with the swipe to close #23

Closed adam-codersgu closed 1 year ago

adam-codersgu commented 1 year ago

If you drag then pause but without releasing, the fragment returns to the top. This needs to be prevented, potentially by only triggering onDismiss when ACTION_UP occurs

Addition: I also want this ticket to explore the conflict between the playback animations and drag to close. Perhaps the drag to close layout should be disabled if an animation element is selected (if this is even possible)? At the very least, need to stop animation items from becoming frozen if touch focus inadvertently shifts from the animation element to the artwork

adam-codersgu commented 1 year ago

Resolved on master branch

adam-codersgu commented 1 year ago

Reopening because the issue is still there. It seems each time the playback progress indicator increases in value, the motion is annulled

adam-codersgu commented 1 year ago

Might be worth adding a log listener to the motion events to see what is being triggered and when

adam-codersgu commented 1 year ago

Bug now fixed and the custom animation and pull to close features now coordinate effectively