search

adam-golab / react-developer-roadmap

Roadmap to becoming a React developer
Other
18.72k stars 2.03k forks source link

Feature/japanese #81

Closed sunasun closed 5 years ago

sunasun commented 5 years ago

What this PR does?

Add Japanese translation file, readme and roadmap.

Why are you adding given library? (Short description why do you think that this library is important)

Nothing.

Screenshots (part that you modified is enough) Before:

After changes:

adam-golab commented 5 years ago

Thanks for contributing @sunasun.

Overall it seems ok to me, but the links in the readmes don't work. It's caused by the wrong name of the file README-ja.md. Links point to README-JA.md. It may work locally if you have a case-insensitive file system. But for GitHub, it makes a difference.

Could you rename the file to README-JA.md?

sunasun commented 5 years ago

Hi @adam-golab !!

Sorry for my mistake... I already fixed it. Please let me know if you notice something else.

Thanks for your time.