search

adam-hanna / jwt-auth

This package provides json web token (jwt) middleware for goLang http servers
MIT License
231 stars 43 forks source link

Nice package! #1

Closed bketelsen closed 8 years ago

bketelsen commented 8 years ago

Looked through the code and examples, this is a nice looking JWT package. I do have a suggestion though: rename the /src directory to /jwt so the package name is jwt. A package name of "src" is very confusing, and not idiomatic in Go. I'm looking forward to playing with this.

adam-hanna commented 8 years ago

Hi Brian,

Thanks so much for the encouragement.

I'll definitely rename that folder, ASAP. Agreed the name "src" isn't the best option.

Thanks much for the feedback. Cheers!

Adam Hanna

On Tue, Jul 19, 2016 at 3:38 PM, Brian Ketelsen notifications@github.com wrote:

Looked through the code and examples, this is a nice looking JWT package. I do have a suggestion though: rename the /src directory to /jwt so the package name is jwt. A package name of "src" is very confusing, and not idiomatic in Go. I'm looking forward to playing with this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adam-hanna/jwt-auth/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AFL2FjoPNnv3QNI5jnV4nILtu6YIsnZmks5qXVHOgaJpZM4JQP0f .