search

adam-hanna / jwt-auth

This package provides json web token (jwt) middleware for goLang http servers
MIT License
231 stars 43 forks source link

Introduced proper header auth #6

Closed ruseinov closed 7 years ago

ruseinov commented 7 years ago

@adam-hanna Just in case you want to consider idiomatic way of auth via headers, I like the library, so modified it to better suit single page apps/mobile auth.

adam-hanna commented 7 years ago

Thanks for this. I agree that it should follow standard header keys. I'll update the tests and merge ASAP. Thanks again.

ruseinov commented 7 years ago

@adam-hanna No problem!

I'd also recommend to make header names adjustable, as this is crucial for usage behind all sorts of proxies and naming convention in general.

adam-hanna commented 7 years ago

Thanks for the suggestions.

I updated the tests and merged with the addition of new options that allow the user to set the auth, refresh and csrf token names.

ruseinov commented 7 years ago

Perfect! On Tue, 9 May 2017 at 22:00, Adam Hanna notifications@github.com wrote:

Thanks for the suggestions.

I updated the tests and merged with the addition of new options that allow the user to set the auth, refresh and csrf token names.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adam-hanna/jwt-auth/pull/6#issuecomment-300284143, or mute the thread https://github.com/notifications/unsubscribe-auth/AAT_kbrRPOWMzSxebKgVWS2XQEKxbVNdks5r4MXWgaJpZM4NI3Au .