adam-ky / pe

0 stars 0 forks source link

Duplicate names are allowed #10

Open adam-ky opened 2 years ago

adam-ky commented 2 years ago

Both are names represent Alex Yeoh, but they differ in white spaces and it is allowed

image.png

nus-pe-bot commented 2 years ago

Team's Response

We accept contacts with the same name but different details (the email is different) as instances like these occur and are not uncommon.

Also, we did not take on the responsibility in the trimming of white spaces as it might be a valid name in different cultures and not up to us to decide, but rather the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As per the guideline in the screenshot below, duplicate detection is not trivial. Perhaps can at least include a warning of a near match case.

image.png

On a side note, I don't quite understand what "might be a valid name in different cultures" mean. Do you mean to say someone's name can have extra whitespaces? I highly doubt any culture has names containing extra trivial whitespaces.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: As this occurrence is not simply a cosmetic issue, it should not be severity.VeryLow.

image.png