adam-ky / pe

0 stars 0 forks source link

Overzealous input validation for remark #11

Open adam-ky opened 2 years ago

adam-ky commented 2 years ago

Perhaps can include a good reason to users why remarks can only be 52 characters long?

image.png

nus-pe-bot commented 2 years ago

Team's Response

As a remark is conventionally not meant to be in big paragraphs or full sentences, we gave the limit of 52 characters, also to make it present nicer on the GUI (and not truncated in the event of an overflow)

It would be unlikely that a TA would have to add so much details in the remark field, or could do so in point form.

Hence we accept the bug but propose a lower severity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Let's first discuss why this isn't a severity.VeryLow issue: it's not simply a cosmetic issue.

image.png

Next, I suggest the severity either be Low or Medium because while your response is completely valid, it is subjective.

For example,

Also, I still don't understand where the number 52 came from, but nonetheless, you have a point to prevent users from typing too much, such as to maintain visual consistency in GUI.

To conclude for this issue, let's go with either severity.Low or severity.Medium :)