search

adam-lynch / back-of-your-hand

How well do you know your area? Test your knowledge by locating streets with this game.
https://backofyourhand.com
Mozilla Public License 2.0
79 stars 9 forks source link

Level chances for choosing streets #34

Closed johrpan closed 2 years ago

johrpan commented 2 years ago

Previously, some streets had considerably higher chances to be chosen. The reason for that was that they appeared multiple times in the set due to their construction of multiple separate segments. This is fixed by deduplicating the street set before choosing a street.

A possible side-effect to consider is the handling of streets that are actually existing multiple times in separate locations of the selected area. Those streets will (each on their own) have a lesser chance of being selected. However, in my opinion, this is a non-issue, because this is a really uncommon case and they will be treated as one street anyway. I just wanted to point that out.

I also added the /.vscode configuration directory to the .gitignore file.

johrpan commented 2 years ago

This will probably fix #20.

adam-lynch commented 2 years ago

Fantastic. Thanks so much for contributing! Yes, this is exactly what was wrong.

I also added the /.vscode configuration directory to the .gitignore file.

In case you don't know, you can configure a global .gitignore file so no matter which repository you're in, .vscode is ignored. This is usually my preference (i.e. the project's .gitignore would only contain project-specific rules) but with a project like this, I bet it would come up over and over again, so it's fine.

Thanks again!