Add dynamic street exclusion feature

adam-lynch / back-of-your-hand

How well do you know your area? Test your knowledge by locating streets with this game.

https://backofyourhand.com

Mozilla Public License 2.0

79 stars 9 forks source link

Add dynamic street exclusion feature #62

Open baso53 opened 2 months ago

baso53 commented 2 months ago

These changes enable adding a street exclusion dynamically once you submit the answer for a particular street. This is useful (for me at least ) when using the app for exercise, so you can skip the streets you know in the future.

I also added the functionality to not include any duplicate streets in the final street list for a game.

adam-lynch commented 2 months ago

Hey thanks so much. Nice idea!

Forgive me but I'm very busy right now so I can't give it a proper review and run the code yet. In the meantime...

Users should probably be able to reset/remove all exclusions right?
Right now if you select an area and there are not enough streets, there's a message shown. Should that message be modified? Should it fill the remaining amount with excluded streets? (I doubt you'd want that)
I'm surprised there could be duplicates. Was this always possible or is it related to your new code?

baso53 commented 1 month ago

Thanks for the reply.

Yes, this would make the most sense. Do you think this would be okay to add in the settings panel?
I think the message is still okay. Maybe we could modify it to signify that the exclusions are taken into account, but in my opinion it's clear as it is now.
Depends on what you mean by duplicates. If you have a low number of questions selected, there is a high probability that the getRandomItem method will generate the same index multiple times, so the final question list for a round could have duplicates.