search

adam-lynch / ked

The first Corkonian scripting language
http://adam-lynch.github.io/ked/
80 stars 8 forks source link

Some small suggestions from @MaximusV #2

Open adam-lynch opened 11 years ago

adam-lynch commented 11 years ago

Here lad, you've made a great start! Just a few thoughts:

  1. Needs more 'boy'
  2. Alias 'stallTheBeans()' for holdOn() - not sure if this is actually Cork or just some weird Ballincollig thing
  3. isTheBopOff as 'extends' keyword for future OO features e.g class Tanora isTheBopOff SoftDrink
  4. Define 'main' function as 'Pana'

Just the first few that came to mind. Sound!

  1. Yeah, I know. It's hard to fit it in though.
  2. Yep, will do.
  3. How about isTheBopOffHisFather / isTheHeadOffHisFather? E.g. class Tanora isTheHeadOffHisFather FizzyDrink. I'll have to get a Tanora joke in there too, thanks.
  4. Not sure about this one.

I'm going to add a list of contributors to the wiki (with your name in it) since not everyone will be contributing via actual pull-requests.

MaximusV commented 11 years ago

Ah, sorry, didn't realise that Issues is how Github handles project management stuff, not very used to it.

  1. Agree, it's hard to see where it can fit in.
  2. I think I was maybe thinking of stallTheBall, are you familiar with these terms at all?
  3. Yeah, theHeadOffHisFather works quite nicely!
  4. Just thought it's be nice to get Pana in there in some way

Well cheers, I'm a bit busy with my degree at the moment but maybe once I'm finished this May I can contribute properly through pull requests. Also, this isn't exactly my area of expertise, I'll need a bit of time to get to grips with the existing source.

Ok, last non-productive comment I swear.

DogPawHat commented 11 years ago

I heard the term "Stall the ball" once on a sound clip that I used to have on my moble phone called "How to learn Dublineese". So it might not work in a Corkonian context.

Of course, being only a half-Corkman that grew up in Galway with a generic accent that get me mistaken for American by taxi drivers across the country, I will defer to the judgement of the experts :grinning:

adam-lynch commented 11 years ago

@MaximusV: No problem. "Issue" is a little unintuitive. No bother at all, I don't mind doing it either. Nah, keep the contributions coming!

I think "stall on" is the "most Cork" variant, in my opinion. Agreed?