adam-may / hudson-tray-tracker

Automatically exported from code.google.com/p/hudson-tray-tracker
0 stars 0 forks source link

Cannot communicate with a server with an untrusted/self signed SSL certificate #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a hudson instance on a server with a self signed certificate.
2. Try to point Tray Tracker to that server 

What is the expected output? What do you see instead?
I expect to see server statistics, but instead it can't communicate with the 
server.

What version of the product are you using? On what operating system?
0.10.3 on Win 7 64-bit

Please provide any additional information below.
I've actually downloaded the code and fixed this locally on my machine.  I 
cannot add a new setting to the UI because I can't load the WinForms in 
designer mode, I get a licensing error.

I've attached the patch that includes everything but adding a checkbox on the 
server dialog for Ignoring Untrusted Certificates.

I even included the bit where it reads it from the config file.  Feel free to 
use the patch as is, modify it, do whatever you'd like, but I'm hoping I'll 
help other folks in the same situation :)

Original issue reported on code.google.com by cub...@gmail.com on 18 Jun 2010 at 1:45

Attachments:

GoogleCodeExporter commented 9 years ago
I've added another patch file for the current version of the Tracker.  Hoping 
you get a chance to look at it.

Original comment by cub...@gmail.com on 20 Jul 2010 at 12:45

Attachments:

GoogleCodeExporter commented 9 years ago
I forgot to give you feedback. Sorry.

I had started integrating the patch until I realized the code to ignore 
untrusted certificates was actually globally ignoring all certificates. This is 
an issue because there are several threads running concurrently, and 
potentially requests going simultaneously to different servers. 

I think we should either make the setting global to all servers, or better, 
find a way to ignore untrusted certificates on a request basis instead of 
globally. Any thoughts?

Original comment by Alexis.S...@gmail.com on 20 Jul 2010 at 1:55

GoogleCodeExporter commented 9 years ago
Alexis,  thanks for the feedback.  I went with my default, which is the 
simplest thing that will work, admittedly, not 100% understanding the code base 
:)

With this new requirement in mind, I'll take a look at it this weekend and see 
if I can make the patch more robust.

Thanks for your feedback!

Original comment by cub...@gmail.com on 20 Jul 2010 at 6:36

GoogleCodeExporter commented 9 years ago
This was a long weekend :)

But, I think this works the right way.  I tested it as best I could, and it 
seems to work well.

Let me know what you think.

Original comment by cub...@gmail.com on 16 Aug 2010 at 1:19

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch! There was a still a thread-safety issue as the callback 
might be added/removed by several threads concurrently, but I managed to fix 
it. It will be released in the next version.

Original comment by Alexis.S...@gmail.com on 19 Aug 2010 at 8:23

GoogleCodeExporter commented 9 years ago
Alexis, that's awesome, thanks!

Original comment by cub...@gmail.com on 19 Aug 2010 at 1:33

GoogleCodeExporter commented 9 years ago
Also, I was wondering, I have Windows 7, and I wanted to see if I could help by 
adding some Windows 7 features to tray tracker.  For example, support for 
jumplists, maybe Aero Peek for seeing the status of projects, progress bars 
when projects are building, etc.

Should I hack it on my end and send you patches, or is there another way you'd 
like to collaborate on this?

Original comment by cub...@gmail.com on 19 Aug 2010 at 1:36

GoogleCodeExporter commented 9 years ago
Sounds like a good idea to add Windows 7 features! I'm not using Windows 7 on 
my development computer but I would be glad to integrate your patches and test 
them on a virtual machine. Thanks!

Original comment by Alexis.S...@gmail.com on 19 Aug 2010 at 2:08

GoogleCodeExporter commented 9 years ago
Issue 57 has been merged into this issue.

Original comment by Alexis.S...@gmail.com on 5 Sep 2010 at 10:52