adam-singer / dart-carte-du-jour

Pub documentation generation system
www.dartdocs.org
Other
25 stars 8 forks source link

Make 404 pages package-specific #77

Open nex3 opened 10 years ago

nex3 commented 10 years ago

The default 404 page is used for all 404 pages, including those for packages whose documentation failed to build. Since the server knows the package and version that the user is requesting, it would be nice if it would look up the corresponding build log and include a link (or better, render it inline) along with instructions about how to fix the issue.

adam-singer commented 10 years ago

@nex3 will look into this. All content is served up from Cloud Storage. I think we could make the 404.html page more lively by running some client side script code to look at the query url and fetch the logs.

nex3 commented 10 years ago

Another possibility would be to upload a custom error page for every build that fails.

adam-singer commented 10 years ago

@nex3 I do like that idea. This would also be related to the following issue https://github.com/financeCoding/dart-carte-du-jour/issues/54

Downside is it would require a full build of failed packages to be done. Could script around this by doing a custom datastore query and adding those packages to a queued build. Doing it all in one shot.