adam-stokes / juju-layer-ruby

Juju charms.reactive layer for Ruby
MIT License
3 stars 3 forks source link

http-proxy setting should apply to both http and https proxies #13

Open dave-lawson opened 7 years ago

dave-lawson commented 7 years ago

Currently the http-proxy setting is implemented via the set_proxy wrapper which returns a commandline with "env http_proxy={}" filled with the config value of http-proxy. Unfortunately, the default value for ruby-mirror is an https site and this does not in fact work. Ruby will repeatedly fail to download without any error message at all:

2017-10-18 01:29:58 INFO juju-log Problem downlading Ruby: []

^^ Like so. Ideally the set_proxy call should set both the http_proxy and https_proxy variables, alternatively the ruby mirror default could be set to the http version of cache.ruby-lang.org with a note in the config descriptions for both ruby-mirror and http-proxy config items that only http sites will work with the proxy.