Refactors ruby layer - Githubissues

adam-stokes / juju-layer-ruby

Juju charms.reactive layer for Ruby

MIT License

3 stars 3 forks source link

Refactors ruby layer #16

Closed adam-stokes closed 5 years ago

adam-stokes commented 5 years ago

Compatibility with previous layer retained
Will install via snapstore if snap-version is set and no ruby-version set, otherwise ruby-version takes precedence
Add travis-ci, linting, black formatting
Removed http/s-proxy from config as commands will now inherit from host os environment variables

Signed-off-by: Adam Stokes battlemidget@users.noreply.github.com

adam-stokes commented 5 years ago

ref #15, @mthaddon do you have a charm I can include in this repo (maybe the scm repo for cs:~mthaddon/discourse) for integration testing? Would also like a review on this PR

mthaddon commented 5 years ago

Per discussions IRL, probably best to use the ubuntu charm and install ruby as an integration test.

adam-stokes commented 5 years ago

I would prefer to just stick with snaps, @mthaddon any objections? And if so would layer-snap cover our needs with some helpers wrapped around bundler and gem?

mthaddon commented 5 years ago

I don't have any objections to snaps only.

I don't know enough about the details to know if layer-snap with some helpers wrapped around bundler and gem would work, but it's quite possible it might.

adam-stokes commented 5 years ago

Cool, ill update the PR