adam-werner / Our.Umbraco.StorageProviders.AWSS3

An implementation of the Umbraco IFileSystem connecting your Umbraco Media section to an AWS S3 Storage bucket featuring middleware serving up media files from the `/media` path and ImageSharp image provider/cache.
MIT License
17 stars 10 forks source link

AWSS3FileSystemImageCache is not getting AWSOptions from DI #6

Open andrei-ufst opened 1 year ago

andrei-ufst commented 1 year ago

The issue with this is that if I'm configuring AWSOptions at startup programmatically or change some values programmatically, my changes will not be used, because AWSS3FileSystemImageCache will always load AWSOptions from json configs via IConfiguration.GetAWSOptions().

Or if I have AWSOptions configured with another name than the default "AWS" and want to load them with IConfiguration.GetAWSOptions("MyCustomAWS_SectionName"), it would not work either.

Would be nice to have AWSOptions injected into AWSS3FileSystemImageCache via DI, since it is registered into DI via composer anyway.