adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
572 stars 34 forks source link

Back tick character causes strange behaviour #17

Closed Adzjective closed 4 years ago

Adzjective commented 4 years ago

When using the Delugia Nerd Font the back tick character is not displaying correctly.

This is quite apparent in JavaScript code that uses a template literal.

const displayText = /api/Person/${personId}; image This seems to move the back tick over the semi colon making it harder to determine if the backtick is actually present.

const displayText = someFunction(/api/person/${personId}); image With this issue when combined with a closing bracket the back tick is removed but the character remains when you move the cursor with the arrow keys.

Finii commented 4 years ago

Which editor are you using? Can you also show the font version you are using?

Finii commented 4 years ago

Looks good in Visual Studio Code OSS, with and without ligatures enabled.

Screenshot from 2019-10-29 10-59-52

I have the most recent Delugia (non-complete) installed (i.e. 1910.04.1):

Screenshot from 2019-10-29 11-03-47

Adzjective commented 4 years ago

Using the v1910.04.1 font

Visual Studio 2017 (15.9.17) Windows Terminal (0.6.2951.0)

Example from Windows Terminal image

Seems to work fine in VS Code (1.39.2)

Adzjective commented 4 years ago

Not sure if it's related but after unblocking the font file in windows it's working fine now.

Finii commented 4 years ago

Fine :+1: And now I also have Visual Studio 17 Community (15.9.16) on my Windows test box:

Screenshot from 2019-10-29 11-58-45

There it works okay, all fresh installed. Probably you had the old (broken) revision lurking somewhere in the depths of Windows?

If you feel this solved, maybe you can close this issue?

Adzjective commented 4 years ago

I removed the old version and installed the latest version. I am not 100% sure if Visual Studio had picked it up. When I unblocked the file in Explorer it all started working. 🤷‍♂

Finii commented 4 years ago

I don't even know what unblocking in Explorer means at all :-D Fine that this seems to be solved.

The backtick is specifically patched, differently from all other glyphs, so this might have been a regression of #5